Skip to content

Add migration to fix the old broken merge-bases#10604

Merged
lafriks merged 4 commits into
go-gitea:masterfrom
zeripath:fix-merge-base-migration
Mar 5, 2020
Merged

Add migration to fix the old broken merge-bases#10604
lafriks merged 4 commits into
go-gitea:masterfrom
zeripath:fix-merge-base-migration

Conversation

@zeripath
Copy link
Copy Markdown
Contributor

@zeripath zeripath commented Mar 4, 2020

#10586 fixed the merge-bases for current PRs but did not fix the merge-base for merged PRs.

This PR adds a new migration that will run through all PRs in the system and recalculates the merge-bases.

@zeripath zeripath added this to the 1.12.0 milestone Mar 4, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 4, 2020

Codecov Report

Merging #10604 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10604      +/-   ##
==========================================
- Coverage    43.7%   43.69%   -0.02%     
==========================================
  Files         585      586       +1     
  Lines       82031    82098      +67     
==========================================
+ Hits        35852    35870      +18     
- Misses      41737    41788      +51     
+ Partials     4442     4440       -2
Impacted Files Coverage Δ
models/migrations/migrations.go 4.16% <ø> (ø) ⬆️
models/migrations/v128.go 0% <0%> (ø)
modules/indexer/stats/queue.go 62.5% <0%> (-18.75%) ⬇️
modules/indexer/stats/db.go 40.62% <0%> (-9.38%) ⬇️
modules/git/utils.go 65.67% <0%> (-4.48%) ⬇️
modules/queue/workerpool.go 56.93% <0%> (-1.07%) ⬇️
modules/git/repo.go 46.78% <0%> (-0.92%) ⬇️
models/notification.go 64.71% <0%> (+0.83%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afa1e1a...4806b80. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2020
guillep2k
guillep2k approved these changes Mar 4, 2020
View reviewed changes
Comment thread models/migrations/v128.go
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 4, 2020
@lafriks @guillep2k
Update models/migrations/v128.go
895e5c5 
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2020
@lafriks
Copy link
Copy Markdown
Member

lafriks commented Mar 5, 2020

make LG-TM work

@lafriks lafriks merged commit 6420f17 into go-gitea:master Mar 5, 2020
@zeripath zeripath deleted the fix-merge-base-migration branch March 5, 2020 07:23
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@zeripath @codecov-io @lafriks @guillep2k @GiteaBot